fix: --strict flag when using conftest verify
#866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this `conftest verify --strict` does not fail in situations where running `conftest test --strict` would. I think this was probably an oversight with open-policy-agent#798 and it was expected that `conftest verify --strict` should behave the same as `conftest test --strict`. Without this change the behaviour is: ``` $ go run . verify --policy examples/strict-rules/policy --strict 0 tests, 0 passed, 0 warnings, 0 failures, 0 exceptions, 0 skipped ``` With this change the behaviour is: ``` $ go run . verify --policy examples/strict-rules/policy --strict Error: running verification: load: loading policies: get compiler: 4 errors occurred: examples/strict-rules/policy/lenient.rego:6: rego_compile_error: assigned var b unused examples/strict-rules/policy/lenient.rego:7: rego_compile_error: assigned var x unused examples/strict-rules/policy/lenient.rego:11: rego_compile_error: assigned var c unused examples/strict-rules/policy/lenient.rego:14: rego_compile_error: unused argument y. (hint: use _ (wildcard variable) instead) exit status 1 ``` Signed-off-by: Sam Crang <sam.crang@gmail.com>
boranx
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this
conftest verify --strictdoes not fail in situations where runningconftest test --strictwould.I think this was probably an oversight with #798 and it was expected that
conftest verify --strictshould behave the same asconftest test --strict.Without this change the behaviour is:
With this change the behaviour is: