Implement option for custom output destinations in output.Get()
#877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Bestavros <mbestavr@redhat.com>
mbestavros
force-pushed
the
add-output-file-options
branch
2 times, most recently
from
58280a3 to
ebdbf09
Compare
|
That won't have an effect on how the cli outputs the result, will it? |
@boranx It shouldn't. Just allowing an option to redirect that output somewhere else.
That's why I proposed it! 😄
|
boranx
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
output.Get()always defaults to creating a newOutputterobject that writes toos.Stdout; however, it's possible that a different output channel is desired.This PR adds an option to allow a different
Fileobject as output when callingGet().Resolves #879.