Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only raise problematic if error when rule has no name set #935

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

jalseth
Copy link
Member

@jalseth jalseth commented Mar 31, 2024

If the rule has a name set, that means there isn't problematic use of the 'if' keyword without 'contains' so we can skip those.


Fixes #934

If the rule has a name set, that means there isn't problematic
use of the 'if' keyword without 'contains' so we can skip those.

Signed-off-by: James Alseth <james@jalseth.me>
Copy link
Member

@jpreese jpreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jalseth jalseth merged commit 1989c6c into master Mar 31, 2024
7 checks passed
@jalseth jalseth deleted the badifbug branch March 31, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper if Usage seems to miss a valid case
2 participants