Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable saving and restoring full simulation state #777

Open
wants to merge 1 commit into
base: dev/state-persistence
Choose a base branch
from

Conversation

kyllingstad
Copy link
Member

@kyllingstad kyllingstad commented Nov 6, 2024

This closes #768. Some changes may warrant a bit of extra explanation:

execution and algorithm: I have taken one step towards prohibiting adding/removing sub-simulators after the co-simulation has begun, as decided in #771. In particular, I've added the execution::initialize() function, which marks the point where such changes are no longer allowed. (This is a backwards-compatible change, because it gets automatically called by execution::step() if it hasn't been called manually.)

slave_simulator: The changes in slave_simulator.cpp really ought to have been included in #769. Unfortunately, I didn't realise they were necessary before it was all put into the context of saving algorithm and execution state. Basically, I thought I could get away with just saving each FMU's internal state, but it turns out that we also need to save the slave_simulator "get" and "set" caches.

(For those interested in the nitty-gritties, this is due to some subtleties regarding exactly when the cache values are set in the course of a co-simulation, relative to when the values are passed to the FMU. At the end of an "algorithm step", the "set cache" is out of sync with the FMUs input variables, and won't be synced before the next step. Simply performing an additional sync prior to saving the state is not sufficient, because that could have an effect on the FMUs output variables, thus invalidating the "get cache". That could in principle be updated too, but then the slave_simulator is in a whole different state from where it was when we started to save the state.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant