Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the unit conversion in the EMF Exporter #35937

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enhance the unit conversion in the EMF Exporter #35937

wants to merge 1 commit into from
+36 −2

Conversation

bjrara
Copy link
Contributor

@bjrara bjrara commented Oct 22, 2024 •
edited
Loading

Description

  1. Fix bits unit conversion.
  2. Use default unit None in translating unit type 1 and ns.

Testing

  • Unit test.
  • E2E test.

Documentation

@bjrara bjrara requested a review from a team as a code owner October 22, 2024 18:53
@github-actions github-actions bot added the exporter/awsemf awsemf exporter label Oct 22, 2024
@bjrara bjrara changed the title Enhance the unit conversion in emf exporter Enhance the unit conversion in the EMF Exporter Oct 22, 2024
@bjrara bjrara mentioned this pull request Oct 22, 2024
Merged
@bjrara bjrara force-pushed the main branch 5 times, most recently from fb16232 to ecaebb9 Compare October 22, 2024 21:10
mxiamxia
mxiamxia approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjrara bjrara force-pushed the main branch 2 times, most recently from fe4f4ac to 8327fcc Compare October 24, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxiamxia mxiamxia mxiamxia approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

@bryan-aguilar bryan-aguilar Awaiting requested review from bryan-aguilar

At least 1 approving review is required to merge this pull request.

Assignees

@dmitryax dmitryax

Labels
exporter/awsemf awsemf exporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bjrara @Aneurysm9 @mxiamxia @dmitryax