Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/clickhouse] Fix incorrect ServiceName set for Logs Records #36350

Merged
merged 4 commits into from
Nov 22, 2024
Merged

[exporter/clickhouse] Fix incorrect ServiceName set for Logs Records #36350

merged 4 commits into from
Nov 22, 2024
+68 −1

Conversation

Fiery-Fenix
Copy link
Contributor

Description

Fixing a bug in clickhouseexporter when ServiceName field in ClickHouse for otel_logs table is set from previous Log Record, when current LogRecord doesn't have service.name set

Link to tracking issue

Fixes #36349

Testing

Respective unit test is added to code

@Fiery-Fenix Fiery-Fenix requested review from dmitryax and a team as code owners November 13, 2024 15:08
@hanjm
Copy link
Member

hanjm commented Nov 15, 2024

LGTM

@rpsadarangani
Copy link

any plans when this will be merge, We are facing the same issue

@ChrsMark
Copy link
Member

@SpencerTorres @Frapschen could you take a look?

SpencerTorres
SpencerTorres approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@SpencerTorres SpencerTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. I wonder if this affects other telemetry types

@Fiery-Fenix
Copy link
Contributor Author

Fiery-Fenix commented Nov 19, 2024 •
edited
Loading

Nice find. I wonder if this affects other telemetry types

Other types are not affected, you can see some proofs in #36349

@rpsadarangani
Copy link

Hi @Fiery-Fenix @SpencerTorres, any idea when this will be merged and deployed?

@SpencerTorres
Copy link
Member

There's multiple approvals but we need someone with permission to merge. I cannot merge. Usually @crobert-1 or @dmitryax have access

@ChrsMark ChrsMark added the ready to merge Code review completed; ready to merge by maintainers label Nov 22, 2024
@codeboten codeboten merged commit 520716b into open-telemetry:main Nov 22, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpencerTorres SpencerTorres SpencerTorres approved these changes

@ChrsMark ChrsMark ChrsMark approved these changes

@hanjm hanjm hanjm approved these changes

@codeboten codeboten codeboten approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@Frapschen Frapschen Awaiting requested review from Frapschen

Assignees

@ChrsMark ChrsMark

Labels
exporter/clickhouse ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
next release
Development

Successfully merging this pull request may close these issues.

[exporter/clickhouse] Incorrect ServiceName set for Logs Records
6 participants
@Fiery-Fenix @hanjm @rpsadarangani @ChrsMark @SpencerTorres @codeboten