[connector/signaltometrics] Add boilerplate for the connector #36454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahsivjar
force-pushed
the
add-signaltometrics-connector
branch
from
dd4cd8a
to
51abe4d
Compare
ChrsMark
reviewed
Nov 20, 2024
|
@lahsivjar I changed the description to avoid closing the original issue after this PR gets merged. Let's leave the issue open until the competent is landed. |
ChrsMark
reviewed
Nov 20, 2024
ChrsMark
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Thank's for adding the additional context @lahsivjar! I've left some minor comments but I think we can proceed with the specific design.
ChrsMark
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds boilerplate code for a new signal to metrics connector.
Link to tracking issue
Part of #35930
Testing
Unit tests provided as required.
Documentation
Added basic README. Will add more details with future commits.
CC: @ChrsMark