config: remove incorrect comment #6090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue to return the SDK was implemented but the TODO was left behind. Removing it in this PR. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
dashpole
approved these changes
Sep 5, 2024
dashpole
added
the
Skip Changelog
|
😅 Almost certain that my change didnt cause: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6090 +/- ##
=====================================
Coverage 65.7% 65.7%
=====================================
Files 203 203
Lines 13037 13037
=====================================
Hits 8568 8568
Misses 4206 4206
Partials 263 263
|
dmathieu
approved these changes
Sep 6, 2024
hanyuancheung
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue to return the SDK was implemented but the TODO was left behind. Removing it in this PR.