Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variable OTEL_EXPORTER_OTLP_CHANNEL_OPTIONS for grpc channel options #4284

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vishaalram02
Copy link

@vishaalram02 vishaalram02 commented Nov 14, 2024

Description

Fixes #4278. Also adds support for many other grpc core configurations.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Happy to add unit tests, but wanted to get an initial review first on the changes.

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Copy link

linux-foundation-easycla bot commented Nov 14, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@vishaalram02 vishaalram02 marked this pull request as ready for review November 14, 2024 22:29
@vishaalram02 vishaalram02 requested a review from a team as a code owner November 14, 2024 22:29
@vishaalram02
Copy link
Author

@xrmx Was wondering if you have the chance to take a quick look at this?

@xrmx
Copy link
Contributor

xrmx commented Nov 19, 2024

These env vars come from https://opentelemetry.io/docs/specs/otel/protocol/exporter/ , if yours is custom to the python agent we can't use the same prefix. Do other languages have something like this?

@vishaalram02
Copy link
Author

Ah this is specific to https://github.com/grpc/grpc which I don't believe every languages uses. If it doesn't make sense to introduce these options in otel python, this may be more of an issue with the underlying library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an environment variable for overriding gRPC default authority
2 participants