Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add history heading ID to fr what-is-opentelemetry page #5559

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Nov 8, 2024

Part of #5555

@opentelemetrybot opentelemetrybot requested review from a team November 8, 2024 08:48
@dmathieu dmathieu marked this pull request as ready for review November 8, 2024 08:52
@dmathieu dmathieu requested a review from a team as a code owner November 8, 2024 08:52
@svrnm
Copy link
Member

svrnm commented Nov 8, 2024

@chalin PTAL

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thank you for quickly addressing the link-check failure for French pages.

@opentelemetrybot opentelemetrybot requested review from a team November 8, 2024 10:56
@chalin chalin added this pull request to the merge queue Nov 8, 2024
Merged via the queue into open-telemetry:main with commit 59ae71f Nov 8, 2024
17 checks passed
@dmathieu dmathieu deleted the fr-heading-ids branch November 8, 2024 12:58
Comment on lines -19 to -20
- ^fr/docs/concepts/glossary/
# TODO drop next lines after https://github.com/open-telemetry/opentelemetry.io/issues/5555 is fixed for these pages:
Copy link
Contributor

@chalin chalin Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my bad, this should have been deleted from content/fr/docs/what-is-opentelemetry.md. Let me figure out why the build checks didn't report this.

Fixed via:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants