Intentional vulnerable #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+23
to
+39
| app.get('/login', (req, res) => { | ||
| const user = req.query.username; | ||
| const pass = req.query.password; | ||
|
|
||
| // Concatenation using a different pattern to obscure SQL injection vulnerability | ||
| const query = ['SELECT * FROM users WHERE username = "', user, '" AND password = "', pass, '"'].join(''); | ||
|
|
||
| db.get(query, (err, row) => { | ||
| if (err) { | ||
| res.status(500).send('Internal Server Error'); | ||
| } else if (row) { | ||
| res.send('Login successful!'); | ||
| } else { | ||
| res.send('Invalid credentials'); | ||
| } | ||
| }); | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting High
| // Slightly obfuscated SQL Injection vulnerability | ||
| app.get('/login', (req, res) => { | ||
| const user = req.query.username; | ||
| const pass = req.query.password; |
Check warning
Code scanning / CodeQL
Sensitive data read from GET request Medium
| // Concatenation using a different pattern to obscure SQL injection vulnerability | ||
| const query = ['SELECT * FROM users WHERE username = "', user, '" AND password = "', pass, '"'].join(''); | ||
|
|
||
| db.get(query, (err, row) => { |
Check failure
Code scanning / CodeQL
Database query built from user-controlled sources High
| }; | ||
|
|
||
| // Render profile with potential XSS | ||
| res.send(renderProfile(username)); |
Check failure
Code scanning / CodeQL
Reflected cross-site scripting High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.