Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Abdera example and add the Cobra convention #70

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix Abdera example and add the Cobra convention #70

wants to merge 5 commits into from

Conversation

dagwieers
Copy link

I think my implementation is correct, and does fix a few things from the original output.

Feedback appreciated.

@dagwieers dagwieers changed the title Using the output from the xmljson Abdera implementation Fix Abdera example output and add the Cobra convention May 8, 2017
@dagwieers dagwieers changed the title Fix Abdera example output and add the Cobra convention Fix Abdera example and add the Cobra convention May 8, 2017
@dagwieers
Copy link
Author

I discovered that Cobra (Cisco ACI) and Abdera are sufficiently different to warrant adding the Cobra convention too.

@dagwieers dagwieers mentioned this pull request May 8, 2017
Merged
@dagwieers
Copy link
Author

@philipashlock Any feedback ?

@dagwieers
Copy link
Author

@philipashlock Can we get this merged ? The output is based on the terrific xmljson python library.

@dagwieers
Copy link
Author

Any feedback on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dagwieers