Added SecondChance algorithm to allow you to retry importing nodes th… #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xydan83
changed the title
|
Great job, thanks for the PR. I've added a comment, feel free to ask questions. |
matkonnerth
reviewed
Dec 8, 2023
xydan83
force-pushed
the
Feature-issue246-add-second-chance-for-nodes-without-parents
branch
from
7cd8fb5
to
b3ec7ed
Compare
|
Hello! I changed some details and included the container in the addNodeImpl function. NL_Node no longer has StatusCode. Look here please. |
xydan83
force-pushed
the
Feature-issue246-add-second-chance-for-nodes-without-parents
branch
3 times, most recently
from
8e73796
to
9e3c680
Compare
…at could not be imported because they did not find their parents. This may be the case if we have a node type of Object which has its own parent node type of Variable. For example, this could be a HasHistoricalConfiguration reference type. Also, the status about how many nodes we have imported shows numbers that include nodes that were not imported due to some error.
xydan83
force-pushed
the
Feature-issue246-add-second-chance-for-nodes-without-parents
branch
from
9e3c680
to
e4a3eed
Compare
|
WindowsBuildOnly is using an old version of open62541 (open62541/1.3.1) and we are getting an error.
|
|
Added a couple of tests. |
xydan83
changed the title
|
Thank you, good job! |
xydan83
deleted the
Feature-issue246-add-second-chance-for-nodes-without-parents
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…at could not be imported because they did not find their parents. This may be the case if we have a node type of Object which has its own parent node type of Variable. For example, this could be a HasHistoricalConfiguration reference type. Also, the status about how many nodes we have imported shows numbers that include nodes that were not imported due to some error.