-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dropped frames calculation #15
base: dev
Are you sure you want to change the base?
Conversation
Thank you for the PR! It looks like there are a lot of unrelated changes due to your work being based on Would you mind making your changes to the Thanks! |
It also looks like you are getting some clippy warnings in CI. You can run |
Please also add some tests to assert that the bad cases have been fixed to prevent regressions! Ideally we would also assert that the internal time representation equals the expected representation for the equivalent non-drop values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Understood, I'll update the PR with the change on the dev branch, Clippy warning fixed, and tests added in the next day or two 👍 |
The drop_frame_adjustment function could return a result that was 1-3 frames off. Took a stab at fixing it based on David Heidelberger's pseudocode and it seems to work correctly now.