Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable redirects for Biomodels download #1368

Merged
merged 2 commits into from
Oct 31, 2023
Merged

enable redirects for Biomodels download #1368

merged 2 commits into from
Oct 31, 2023

Conversation

cdiener
Copy link
Member

@cdiener cdiener commented Oct 31, 2023

Quick fix for broken Biomodels downloads. Simply enables redirects in httpx.stream.

Midnighter
Midnighter approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@Midnighter Midnighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fast fix! I also noticed that some BioModels only have omex files now. So we will need some extra code that extracts the SBML document from the archive in future.

@cdiener
Copy link
Member Author

cdiener commented Oct 31, 2023

Well I definitely need to read up on what one files are 🤔

@cdiener cdiener merged commit b27ad4d into opencobra:devel Oct 31, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Midnighter Midnighter Midnighter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Biomodels web io access broekn due to redirects
2 participants
@cdiener @Midnighter