Fixed some bugs in DEMETER/mgPipe #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farid-zare
reviewed
Nov 3, 2024
| @@ -26,7 +26,8 @@ | |||
| % create the pan-models on species level | |||
| panPath=[pwd filesep 'panSpeciesModels']; | |||
|
|
|||
| createPanModels(modPath,panPath,'Species','AGORA',numWorkers); | |||
| builtTaxa = {'Acinetobacter junii','Bacteroides ovatus','Enterobacter cloacae','Megasphaera elsdenii','Ruminococcus flavefaciens'}; | |||
| createPanModels(modPath,panPath,'Species','AGORA_infoFile.xlsx',numWorkers,builtTaxa) | |||
There was a problem hiding this comment.
Hi @almut-heinken
Is it possible that we move these models to COBRA.models and load them using "getDistributedModel" to avoid downloading them? or are these models updating regularly and it is important to always download their latest version?
There was a problem hiding this comment.
Hi @farid-zare
I modified the code to rely on a subset of models. I also opened a pull request on COBRA.models to upload the neccessary models.
There was a problem hiding this comment.
Thanks a million @almut-heinken. This is great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some bugs
I hereby confirm that I have:
developas a target branch (top left drop-down menu)(Note: You may replace [ ] with [X] to check the box)