Merge pull request #687 from HumairAK/fix_default_envoy_route

fix default envoy route behavior
opendatahub-io · Aug 16, 2024 · 25d21af · 25d21af
2 parents 8339af5 + 67fd529
commit 25d21af
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/controllers/dspipeline_params.go b/controllers/dspipeline_params.go
@@ -504,6 +504,9 @@ func (p *DSPAParams) SetupMLMD(dsp *dspa.DataSciencePipelinesApplication, log lo
 			log.Info("MLMD not specified, but is a required component for V2 Pipelines. Including MLMD with default specs.")
 			p.MLMD = &dspa.MLMD{
 				Deploy: true,
+				Envoy: &dspa.Envoy{
+					DeployRoute: true,
+				},
 			}
 		} else if !p.MLMD.Deploy {
 			return fmt.Errorf(MlmdIsRequiredInV2Msg)
@@ -515,7 +518,8 @@ func (p *DSPAParams) SetupMLMD(dsp *dspa.DataSciencePipelinesApplication, log lo
 
 		if p.MLMD.Envoy == nil {
 			p.MLMD.Envoy = &dspa.Envoy{
-				Image: config.GetStringConfigWithDefault(MlmdEnvoyImagePath, config.DefaultImageValue),
+				Image:       config.GetStringConfigWithDefault(MlmdEnvoyImagePath, config.DefaultImageValue),
+				DeployRoute: true,
 			}
 		}
 		if p.MLMD.GRPC == nil {

diff --git a/tests/resources/dspa-external-lite.yaml b/tests/resources/dspa-external-lite.yaml
@@ -41,6 +41,7 @@ spec:
     deploy: true
     envoy:
       image: quay.io/maistra/proxyv2-ubi8:2.5.0
+      deployRoute: false
       resources:
         limits:
           cpu: 20m

diff --git a/tests/resources/dspa-lite.yaml b/tests/resources/dspa-lite.yaml
@@ -41,6 +41,7 @@ spec:
     deploy: true
     envoy:
       image: quay.io/maistra/proxyv2-ubi8:2.5.0
+      deployRoute: false
       resources:
         limits:
           cpu: 20m