Merge pull request #479 from DharmitD/minio-endpt-svc

Adding a variable for minio-service endpoint
opendatahub-io · Nov 21, 2023 · 5dbf012 · 5dbf012
2 parents b8e5b06 + 3708e65
commit 5dbf012
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/config/internal/apiserver/sample-pipeline.yaml.tmpl b/config/internal/apiserver/sample-pipeline.yaml.tmpl
@@ -29,7 +29,7 @@ data:
               "parent_task": "data-prep"}], "validate-model": [{"name": "train-model-model",
               "parent_task": "train-model"}]}'
             tekton.dev/artifact_bucket: mlpipeline
-            tekton.dev/artifact_endpoint: minio-service.kubeflow:9000
+            tekton.dev/artifact_endpoint: ${MINIO_SERVICE_SERVICE_HOST}:${MINIO_SERVICE_SERVICE_PORT}
             tekton.dev/artifact_endpoint_scheme: http://
             tekton.dev/artifact_items: '{"data-prep": [["X_test", "$(workspaces.data-prep.path)/artifacts/$ORIG_PR_NAME/$(context.taskRun.name)/X_test"],
               ["X_train", "$(workspaces.data-prep.path)/artifacts/$ORIG_PR_NAME/$(context.taskRun.name)/X_train"],

diff --git a/controllers/testdata/declarative/case_2/expected/created/sample-pipeline.yaml.tmpl b/controllers/testdata/declarative/case_2/expected/created/sample-pipeline.yaml.tmpl
@@ -29,7 +29,7 @@ data:
               "parent_task": "data-prep"}], "validate-model": [{"name": "train-model-model",
               "parent_task": "train-model"}]}'
             tekton.dev/artifact_bucket: mlpipeline
-            tekton.dev/artifact_endpoint: minio-service.kubeflow:9000
+            tekton.dev/artifact_endpoint: ${MINIO_SERVICE_SERVICE_HOST}:${MINIO_SERVICE_SERVICE_PORT}
             tekton.dev/artifact_endpoint_scheme: http://
             tekton.dev/artifact_items: '{"data-prep": [["X_test", "$(workspaces.data-prep.path)/artifacts/$ORIG_PR_NAME/$(context.taskRun.name)/X_test"],
               ["X_train", "$(workspaces.data-prep.path)/artifacts/$ORIG_PR_NAME/$(context.taskRun.name)/X_train"],

diff --git a/docs/example_pipelines/condition.yaml b/docs/example_pipelines/condition.yaml
@@ -14,7 +14,7 @@ metadata:
       "random-num-2"}], "print-msg-4": [{"name": "random-num-2-Output", "parent_task":
       "random-num-2"}]}'
     tekton.dev/artifact_bucket: mlpipeline
-    tekton.dev/artifact_endpoint: minio-service.kubeflow:9000
+    tekton.dev/artifact_endpoint: ${MINIO_SERVICE_SERVICE_HOST}:${MINIO_SERVICE_SERVICE_PORT}
     tekton.dev/artifact_endpoint_scheme: http://
     tekton.dev/artifact_items: '{"flip-coin": [["Output", "$(results.Output.path)"]],
       "print-msg": [], "print-msg-2": [], "print-msg-3": [], "print-msg-4": [], "random-num":