Add Database and ObjectStorage Health Checks #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmfrasca
force-pushed
the
storage-readiness-conditions
branch
from
3ec6a98
to
6992e9b
Compare
gmfrasca
force-pushed
the
storage-readiness-conditions
branch
2 times, most recently
from
10478fe
to
b4fba5b
Compare
gmfrasca
changed the title
HumairAK
reviewed
Jul 13, 2023
HumairAK
reviewed
Jul 13, 2023
HumairAK
reviewed
Jul 13, 2023
HumairAK
reviewed
Jul 13, 2023
HumairAK
reviewed
Jul 13, 2023
HumairAK
reviewed
Jul 13, 2023
HumairAK
reviewed
Jul 13, 2023
HumairAK
reviewed
Jul 13, 2023
HumairAK
reviewed
Jul 13, 2023
HumairAK
reviewed
Jul 13, 2023
HumairAK
reviewed
Jul 13, 2023
gmfrasca
force-pushed
the
storage-readiness-conditions
branch
2 times, most recently
from
ec253e2
to
dc4c2ab
Compare
- Delays deploying DSPA Manifests until DB and ObjStore Connections are healthy - Introduces status condition of "ComponentDeploymentNotFound" for Required Components with missing Deployments
- Useful for local testing and debugging
gmfrasca
force-pushed
the
storage-readiness-conditions
branch
from
dc4c2ab
to
0563af3
Compare
- specifying Spec.Database.DsiableHealthCheck but not externalDB/mariaDB leads to an issue where the DSPO does not recognize the need for a default DB deployment. This handles that case by including it in the default-deploy behavior
HumairAK
requested changes
Jul 25, 2023
|
functionality wise this lgtm, just a few minor changes above |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amadhusu, rimolive The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149
Description
How Has This Been Tested?
Notes to reviewer:
In it's current state, this makes 'local' runs of the DSPO difficult/impossible, as the Object Store host references internal Services which are not available on an external-running DSPODo we want to add an override mechanism here?spec.database.disableHealthCheckfield and funtionality was added to the DSPA CRD to enable local runsMerge criteria: