Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MLMD components to Network Policy #190

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Add MLMD components to Network Policy #190

merged 1 commit into from
Jul 12, 2023

Conversation

DharmitD
Copy link
Member

@DharmitD DharmitD commented Jun 27, 2023

Closes #160

Description

Adding MLMD components to the DSPA Network Policy, and provide ODH dashboard access to the metadata envoy service.

How Has This Been Tested?

  • Deployed a DSPO and DSPA instance with these updates
  • Deployed an ODH dashboard instance by applying the ODH core kfdef in the same namespace where DSPO was deployed.
  • Ensured that the MLMD components were up, metadata envoy service was running.
  • curled to the envoy service from the dashboard pod.
    $ curl ds-pipeline-metadata-envoy-sample.test-dspa-3.svc.cluster.local:9090 upstream connect error or disconnect/reset before headers. reset reason: remote reset
    Dashboard was able to reach the envoy service.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@DharmitD DharmitD changed the title WIP: Add MLMD components to Network Policy Add MLMD components to Network Policy Jul 7, 2023
@HumairAK
Copy link
Contributor

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7f5f983 into opendatahub-io:main Jul 12, 2023
2 checks passed
@HumairAK HumairAK added the qe/verify Labels to inform qe on issues to verify. label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm qe/verify Labels to inform qe on issues to verify.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update networkpolicy to account for mlmd components
4 participants