-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MLMD components to Network Policy #190
Merged
openshift-merge-robot
merged 1 commit into
opendatahub-io:main
from
DharmitD:mlmd-nw-policy
Jul 12, 2023
Merged
Add MLMD components to Network Policy #190
openshift-merge-robot
merged 1 commit into
opendatahub-io:main
from
DharmitD:mlmd-nw-policy
Jul 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DharmitD
changed the title
WIP: Add MLMD components to Network Policy
Add MLMD components to Network Policy
Jul 7, 2023
gmfrasca
reviewed
Jul 10, 2023
config/internal/common/mlmd-envoy-dashboard-access-policy.yaml.tmpl
Outdated
Show resolved
Hide resolved
HumairAK
reviewed
Jul 10, 2023
gmfrasca
reviewed
Jul 10, 2023
config/internal/common/mlmd-envoy-dashboard-access-policy.yaml.tmpl
Outdated
Show resolved
Hide resolved
HumairAK
reviewed
Jul 10, 2023
config/internal/common/mlmd-envoy-dashboard-access-policy.yaml.tmpl
Outdated
Show resolved
Hide resolved
HumairAK
reviewed
Jul 10, 2023
config/internal/common/mlmd-envoy-dashboard-access-policy.yaml.tmpl
Outdated
Show resolved
Hide resolved
HumairAK
reviewed
Jul 10, 2023
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #160
Description
Adding MLMD components to the DSPA Network Policy, and provide ODH dashboard access to the metadata envoy service.
How Has This Been Tested?
$ curl ds-pipeline-metadata-envoy-sample.test-dspa-3.svc.cluster.local:9090 upstream connect error or disconnect/reset before headers. reset reason: remote reset
Dashboard was able to reach the envoy service.
Merge criteria: