Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RBAC rules for mcad and ray roles #195

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Add RBAC rules for mcad and ray roles #195

merged 1 commit into from
Jul 5, 2023

Conversation

DharmitD
Copy link
Member

@DharmitD DharmitD commented Jul 3, 2023

Add RBAC rules for mcad and ray roles

Follow up to: #158

Description

How Has This Been Tested?

Deployed a DSPO and a DSPA instance, made sure that all DSPA components come up as expected, and not just minio/mariaDB.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from gmfrasca and HumairAK July 3, 2023 20:15
@amadhusu
Copy link
Contributor

amadhusu commented Jul 5, 2023

/lgtm

@HumairAK
Copy link
Contributor

HumairAK commented Jul 5, 2023

/approve

@openshift-ci openshift-ci bot added the approved label Jul 5, 2023
@HumairAK
Copy link
Contributor

HumairAK commented Jul 5, 2023

/hold

@openshift-ci openshift-ci bot removed the lgtm label Jul 5, 2023
@HumairAK
Copy link
Contributor

HumairAK commented Jul 5, 2023

/unhold
/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 543be92 into opendatahub-io:main Jul 5, 2023
2 checks passed
@HumairAK HumairAK added the qe/verify Labels to inform qe on issues to verify. label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm qe/verify Labels to inform qe on issues to verify.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants