Infer the "secure" field in dspa based on scheme #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So now that secure is removed here ... how do you handle setting secure to either true or false in i.e. odh dashboard? |
amadhusu
force-pushed
the
am/157
branch
2 times, most recently
from
c5e820f
to
27325ee
Compare
amadhusu
changed the title
HumairAK
reviewed
Jul 11, 2023
|
@amadhusu can you squash your commits |
HumairAK
reviewed
Jul 11, 2023
HumairAK
reviewed
Jul 11, 2023
amadhusu
force-pushed
the
am/157
branch
2 times, most recently
from
6029935
to
9d7dea7
Compare
HumairAK
reviewed
Jul 13, 2023
Signed-off-by: Achyut Madhusudan <amadhusu@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #157
Description
Infer the "secure" field in dspa based on the scheme which
How Has This Been Tested?
Manually tested this on Openshift Cluster to ensure removing this field doesn't hinder anything.
Merge criteria: