Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Testing GitHub Actions #312

Merged

Conversation

gmfrasca
Copy link
Member

The issue resolved by this Pull Request:

Resolves #284

Description of your changes:

  • Remove old pre-commit go-unit-test check (doesn't work with new tags used in tests)
  • Add Unit Test GitHub Action
  • Add Functional Test GitHub Action

Testing instructions

Verify the Checks on this PR pass :)

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@gmfrasca gmfrasca changed the title Fix ghaction unittests Fix Testing GitHub Actions Aug 31, 2023
Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@HumairAK
Copy link
Contributor

HumairAK commented Sep 1, 2023

/lgtm
/approve

@HumairAK
Copy link
Contributor

HumairAK commented Sep 1, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 1, 2023
@openshift-merge-robot openshift-merge-robot merged commit 5c06277 into opendatahub-io:main Sep 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add/Separate GitHub PR Check into distinct Unit and Functional checks
4 participants