Parameterized HealthCheck Timeouts

[hbelmiro]

The issue resolved by this Pull Request:

Resolves #328

Description of your changes:

Parameterized DBConnectionTimeout and ObjStoreConnectionTimeout.
MaxConcurrentReconciles was already parameterized.

Testing instructions

Set the variables DB_CONNECTION_TIMEOUT and OBJ_STORE_CONNECTION_TIMEOUT, run DSPO, create a DSPA, and ensure the DSPA deploys correctly.

Checklist

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[dsp-developers]

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-433
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/433/head
git checkout -b pullrequest d8289bcddd83160cbbd3f00a2b227bac8a7d0f3f
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-433"

More instructions here on how to deploy and test a Data Science Pipelines Application.

[gmfrasca]

I hate to propose something drastically different, but I feel like these should be configurable fields in the DSPA CRD (ie spec.database.healthchecktimeout and spec.objectStore.healthCheckTimeout) rather than a CLI parameter, perhaps even introducing the concept of a HealthCheck item that has a disabled (previously implemented as Spec.Database.DisableHealthCheck) and new timeout field, which this pr would implement

[dsp-developers]

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-433

[gmfrasca]

needs rebased but otherwise /lgtm

[dsp-developers]

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-433

[DharmitD]

/lgtm

[hbelmiro]

/approve

[DharmitD]

/Approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DharmitD, gmfrasca, hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [DharmitD,gmfrasca]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment