Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dspv2 merge #535

Merged
merged 39 commits into from
Jan 10, 2024
Merged

Dspv2 merge #535

merged 39 commits into from
Jan 10, 2024

Conversation

gmfrasca
Copy link
Member

@gmfrasca gmfrasca commented Jan 8, 2024

Final pull-in PR

Testing instructions

Standard Sanity tests

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

hbelmiro and others added 30 commits December 19, 2023 11:48
@hbelmiro
Fix README.md > Deploy the Operator via ODH
ef183b7 
Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
@hbelmiro
Fixed DataScienceCluster name in README.md
49bdcf5 
Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
@openshift-merge-bot
Merge pull request opendatahub-io#520 from hbelmiro/fix-docs
04148bf 
Fix README.md
Update DSP API Server cABundle error msg
30bbcbc 
Signed-off-by: Piotr Godowski <piotr.godowski@pl.ibm.com>
@openshift-merge-bot
Merge pull request opendatahub-io#529 from pgodowski/feat/improve-cab…
3c0787b 
…undle-error

Update DSP API Server cABundle error msg
@DharmitD
Remove mcad.ibm.com APIGroup
c6abbc3
@openshift-merge-bot
Merge pull request opendatahub-io#530 from DharmitD/remove-mcad
6991f3a 
Remove mcad.ibm.com APIGroup
@HumairAK
Add kind test support for dspa.
efee7ea 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Replace old e2e test suite with ginkgo/gomega systems test.
73b95d8 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Add k8s client configuration for systemtests.
78dea73 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Add client manager for systemtests.
b5b0859 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Add k8s server flags to system test suite.
338a57a 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Add dspa-lite resource, add ns/dspa flags.
b3ceb8f 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Assert on k8s client creation in sys test.
5bf229e 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Add dspa setup/teardown for systest.
c548c3c 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Add DSPA deploy wait to sys test.
c631ab3 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Add dspa tests & skip deploy/cleanup flags.
8a2297a 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Add systest pod ready states & flag timeouts.
0038a63 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Correct linting errors.
efaa455 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Add stub main to pass precommit go build check.
2097dbd 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Add portforwarding logic and working apiserver url.
5585247 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Add pipeline upload test.
e353c07 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Added dspa deploy log messages in sys test.
b62d53d 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Update kind tests to leverage ginkgo system tests.
420a87b 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Add systest readme.
63b6be2 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Switch to local build for images.
1e40fbc 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Add build flags for systests.
6250eaa 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Remove unused action and add licenses.
ee4ef43 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Rename systest to integartion tests.
3167cb5 
The these tests were incorrectly named, the correct nomenclature as per
dsp testing adr is integration tests.

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Add make command for integration tests.
9e15ddc 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
rimolive
rimolive reviewed Jan 8, 2024
View reviewed changes
Copy link
Contributor

@rimolive rimolive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 8, 2024
@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-535
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/535/head
git checkout -b pullrequest ae3f49b1b2f91c91b23234b154f5ec4fcc14f953
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-535"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@openshift-ci openshift-ci bot removed the lgtm label Jan 9, 2024
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-535

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-535

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-535

@rimolive
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 10, 2024
@HumairAK
Copy link
Contributor

/approve

@HumairAK HumairAK merged commit cd786d9 into opendatahub-io:dspv2 Jan 10, 2024
5 of 6 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rimolive rimolive rimolive left review comments

@amadhusu amadhusu Awaiting requested review from amadhusu

@HumairAK HumairAK Awaiting requested review from HumairAK

Assignees

@rimolive rimolive

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gmfrasca @dsp-developers @rimolive @HumairAK @openshift-merge-robot @hbelmiro @DharmitD