Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set caching to False for output_mt_bench_task #242

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

MichaelClifford
Copy link
Collaborator

This PR sets outpiut_mt_bench_task caching option to False. Otherwise, this can lead to instances where the MT-bench data changes, but the MT-bench data artifacts do not get updated, causing a mismatch between the evaluation run and the evaluation values reported.

Signed-off-by: Michael Clifford <mcliffor@redhat.com>
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@tumido tumido merged commit 4602f7d into opendatahub-io:main Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants