Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for controller reconcile, fixes #17 #18

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Add unit test for controller reconcile, fixes #17 #18

merged 1 commit into from
Nov 7, 2023

Conversation

dhirajsb
Copy link
Contributor

@dhirajsb dhirajsb commented Nov 7, 2023

Description

Added unit test modelregistry_controller_test.go for controller reconcile to test that service k8s resources are successfully created.

How Has This Been Tested?

Unit test run using make test passes.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dhirajsb dhirajsb merged commit 4c04ff7 into opendatahub-io:main Nov 7, 2023
2 checks passed
@dhirajsb dhirajsb deleted the unit-test branch November 7, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dhirajsb