Skip to content

Commit

Permalink
chore: remove go from bin (kubeflow#288)
Browse files Browse the repository at this point in the history
Co-authored-by: Isabella do Amaral <idoamara@redhat.com>
  • Loading branch information
tarilabs and isinyaaa committed Aug 21, 2024
1 parent 0c3b497 commit 639661b
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
MKFILE_PATH := $(abspath $(lastword $(MAKEFILE_LIST)))
PROJECT_PATH := $(patsubst %/,%,$(dir $(MKFILE_PATH)))
PROJECT_BIN := $(PROJECT_PATH)/bin
GO := $(PROJECT_BIN)/go1.21.9
GO ?= "$(shell which go)"

# add tools bin directory
PATH := $(PROJECT_BIN):$(PATH)
Expand Down Expand Up @@ -108,10 +108,6 @@ clean:
clean/odh:
rm -Rf ./model-registry

bin/go:
GOBIN=$(PROJECT_BIN) go install golang.org/dl/go1.21.9@latest
$(PROJECT_BIN)/go1.21.9 download

bin/protoc:
./scripts/install_protoc.sh

Expand Down Expand Up @@ -155,7 +151,7 @@ clean/deps:
rm -Rf bin/*

.PHONY: deps
deps: bin/go bin/protoc bin/go-enum bin/protoc-gen-go bin/protoc-gen-go-grpc bin/golangci-lint bin/goverter bin/openapi-generator-cli
deps: bin/protoc bin/go-enum bin/protoc-gen-go bin/protoc-gen-go-grpc bin/golangci-lint bin/goverter bin/openapi-generator-cli

.PHONY: vendor
vendor:
Expand Down

0 comments on commit 639661b

Please sign in to comment.