OAS: fix minor issues and bump version (#29)

* OAS: fixup ID -> Id in parameter names ... to preserve camelCase. Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com> * fix REST api to use ModelVersionUpdate in PATCH method Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> * bump OAS version to v1alpha3 Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com> --------- Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com> Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> Co-authored-by: Matteo Mortari <matteo.mortari@gmail.com>
opendatahub-io · Mar 13, 2024 · 962c78d · 962c78d
1 parent 67d9e4d
commit 962c78d
Show file tree

Hide file tree

Showing 71 changed files with 993 additions and 994 deletions.
diff --git a/api/openapi/model-registry.yaml b/api/openapi/model-registry.yaml
diff --git a/csi/GET_STARTED.md b/csi/GET_STARTED.md
@@ -82,7 +82,7 @@ Then, in the same terminal where you exported `MR_HOSTNAME`, perform the followi
 
 ```bash
 curl --silent -X 'POST' \
-  "$MR_HOSTNAME/api/model_registry/v1alpha2/registered_models" \
+  "$MR_HOSTNAME/api/model_registry/v1alpha3/registered_models" \
   -H 'accept: application/json' \
   -H 'Content-Type: application/json' \
   -d '{
@@ -100,7 +100,7 @@ Expected output:
 
 ```bash
 curl --silent -X 'POST' \
-  "$MR_HOSTNAME/api/model_registry/v1alpha2/model_versions" \
+  "$MR_HOSTNAME/api/model_registry/v1alpha3/model_versions" \
   -H 'accept: application/json' \
   -H 'Content-Type: application/json' \
   -d '{
@@ -121,7 +121,7 @@ This artifact defines where the actual trained model is stored, i.e., `gs://kfse
 
 ```bash
 curl --silent -X 'POST' \
-  "$MR_HOSTNAME/api/model_registry/v1alpha2/model_versions/2/artifacts" \
+  "$MR_HOSTNAME/api/model_registry/v1alpha3/model_versions/2/artifacts" \
   -H 'accept: application/json' \
   -H 'Content-Type: application/json' \
   -d '{
@@ -246,4 +246,4 @@ If you do not have DNS, you can still curl with the ingress gateway external IP
 ```bash
 SERVICE_HOSTNAME=$(kubectl get inferenceservice iris-model -n kserve-test -o jsonpath='{.status.url}' | cut -d "/" -f 3)
 curl -v -H "Host: ${SERVICE_HOSTNAME}" -H "Content-Type: application/json" "http://${INGRESS_HOST}:${INGRESS_PORT}/v1/models/iris-v1:predict" -d @/tmp/iris-input.json
-```
+```
diff --git a/docs/logical_model.md b/docs/logical_model.md
@@ -87,7 +87,7 @@ resulting in:
 
 ```
 curl --silent -X 'GET' \
-  "$MR_HOSTNAME/api/model_registry/v1alpha2/registered_models/1" \                     
+  "$MR_HOSTNAME/api/model_registry/v1alpha3/registered_models/1" \                     
   -H 'accept: application/json' | jq
 {
   "createTimeSinceEpoch": "1707765353963",
@@ -99,7 +99,7 @@ curl --silent -X 'GET' \
 }
 
 curl --silent -X 'GET' \
-  "$MR_HOSTNAME/api/model_registry/v1alpha2/registered_models/1/versions?pageSize=100&orderBy=ID&sortOrder=DESC&nextPageToken=" \
+  "$MR_HOSTNAME/api/model_registry/v1alpha3/registered_models/1/versions?pageSize=100&orderBy=ID&sortOrder=DESC&nextPageToken=" \
   -H 'accept: application/json' | jq 
 {
   "items": [
@@ -120,7 +120,7 @@ curl --silent -X 'GET' \
 }
 
 curl --silent -X 'GET' \
-  "$MR_HOSTNAME/api/model_registry/v1alpha2/model_versions/2/artifacts" \
+  "$MR_HOSTNAME/api/model_registry/v1alpha3/model_versions/2/artifacts" \
   -H 'accept: application/json' | jq
 {
   "items": [
@@ -167,7 +167,7 @@ resulting in:
 
 ```
 curl --silent -X 'GET' \
-  "$MR_HOSTNAME/api/model_registry/v1alpha2/registered_models/3" \       
+  "$MR_HOSTNAME/api/model_registry/v1alpha3/registered_models/3" \       
   -H 'accept: application/json' | jq 
 {
   "createTimeSinceEpoch": "1707765756856",
@@ -179,7 +179,7 @@ curl --silent -X 'GET' \
 }
 
 curl --silent -X 'GET' \
-  "$MR_HOSTNAME/api/model_registry/v1alpha2/registered_models/3/versions?pageSize=100&orderBy=ID&sortOrder=DESC&nextPageToken=" \
+  "$MR_HOSTNAME/api/model_registry/v1alpha3/registered_models/3/versions?pageSize=100&orderBy=ID&sortOrder=DESC&nextPageToken=" \
   -H 'accept: application/json' | jq 
 {
   "items": [
@@ -200,7 +200,7 @@ curl --silent -X 'GET' \
 }
 
 curl --silent -X 'GET' \
-  "$MR_HOSTNAME/api/model_registry/v1alpha2/model_versions/4/artifacts" \                                                       
+  "$MR_HOSTNAME/api/model_registry/v1alpha3/model_versions/4/artifacts" \                                                       
   -H 'accept: application/json' | jq
 {
   "items": [
@@ -247,7 +247,7 @@ resulting in:
 
 ```
 curl --silent -X 'GET' \
-  "$MR_HOSTNAME/api/model_registry/v1alpha2/registered_models/5" \                                                               
+  "$MR_HOSTNAME/api/model_registry/v1alpha3/registered_models/5" \                                                               
   -H 'accept: application/json' | jq 
 {
   "createTimeSinceEpoch": "1707765990857",
@@ -259,7 +259,7 @@ curl --silent -X 'GET' \
 }
 
 curl --silent -X 'GET' \
-  "$MR_HOSTNAME/api/model_registry/v1alpha2/registered_models/5/versions?pageSize=100&orderBy=ID&sortOrder=DESC&nextPageToken=" \
+  "$MR_HOSTNAME/api/model_registry/v1alpha3/registered_models/5/versions?pageSize=100&orderBy=ID&sortOrder=DESC&nextPageToken=" \
   -H 'accept: application/json' | jq 
 {
   "items": [
@@ -290,7 +290,7 @@ curl --silent -X 'GET' \
 }
 
 curl --silent -X 'GET' \
-  "$MR_HOSTNAME/api/model_registry/v1alpha2/model_versions/6/artifacts" \                                                      
+  "$MR_HOSTNAME/api/model_registry/v1alpha3/model_versions/6/artifacts" \                                                      
   -H 'accept: application/json' | jq
 {
   "items": [
@@ -362,7 +362,7 @@ resulting in:
 
 ```
 curl --silent -X 'GET' \
-  "$MR_HOSTNAME/api/model_registry/v1alpha2/registered_models/7" \                                                               
+  "$MR_HOSTNAME/api/model_registry/v1alpha3/registered_models/7" \                                                               
   -H 'accept: application/json' | jq 
 {
   "createTimeSinceEpoch": "1707766117250",
@@ -374,7 +374,7 @@ curl --silent -X 'GET' \
 }
 
 curl --silent -X 'GET' \
-  "$MR_HOSTNAME/api/model_registry/v1alpha2/registered_models/7/versions?pageSize=100&orderBy=ID&sortOrder=DESC&nextPageToken=" \
+  "$MR_HOSTNAME/api/model_registry/v1alpha3/registered_models/7/versions?pageSize=100&orderBy=ID&sortOrder=DESC&nextPageToken=" \
   -H 'accept: application/json' | jq 
 {
   "items": [
@@ -395,7 +395,7 @@ curl --silent -X 'GET' \
 }
 
 curl --silent -X 'GET' \
-  "$MR_HOSTNAME/api/model_registry/v1alpha2/model_versions/8/artifacts" \                                                       
+  "$MR_HOSTNAME/api/model_registry/v1alpha3/model_versions/8/artifacts" \                                                       
   -H 'accept: application/json' | jq
 {
   "items": [

diff --git a/internal/converter/generated/mlmd_openapi_converter.gen.go b/internal/converter/generated/mlmd_openapi_converter.gen.go
diff --git a/internal/converter/generated/openapi_converter.gen.go b/internal/converter/generated/openapi_converter.gen.go