Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from kubeflow:main #121

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented Sep 13, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

isinyaaa and others added 2 commits September 12, 2024 19:57
* py: pager: rename limit to page_size

... to improve semantics.

Closes: #357
Signed-off-by: Isabella do Amaral <idoamara@redhat.com>

* py: fix custom_props typing issue

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>

* py: test pager descending option

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>

* py: update README with suggestion

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>

---------

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
* Set up model registry context and apiHooks

Signed-off-by: lucferbux <lferrnan@redhat.com>

* Add selector core loader

Signed-off-by: lucferbux <lferrnan@redhat.com>

---------

Signed-off-by: lucferbux <lferrnan@redhat.com>
Copy link

openshift-ci bot commented Sep 13, 2024

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.55%. Comparing base (1fb7ad9) to head (cc6455f).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
clients/python/src/model_registry/types/pager.py 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   77.55%   77.55%   -0.01%     
==========================================
  Files          17       23       +6     
  Lines        2090     2094       +4     
  Branches      143      144       +1     
==========================================
+ Hits         1621     1624       +3     
  Misses        275      275              
- Partials      194      195       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarilabs
Copy link
Member

{  failed to get CLI image: unable to tag the override 'cli' image into the amd64-cli:latest: ImageStreamTag.image.openshift.io "amd64-cli:latest" is invalid: metadata: Invalid value: "": may not update fields other than metadata.annotations}

🤔

/retest-required

@tonyxrmdavidson
Copy link

/test images

1 similar comment
@tonyxrmdavidson
Copy link

/test images

Signed-off-by: Alex Creasy <alex@creasy.dev>
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openshift-ci openshift-ci bot added the lgtm label Sep 13, 2024
Copy link

openshift-ci bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pull[bot], tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Sep 13, 2024

@pull[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-odh-model-registry-python-client 95e6b7f link false /test e2e-odh-model-registry-python-client
ci/prow/e2e-odh-mro-optional 95e6b7f link false /test e2e-odh-mro-optional

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0cd206f into opendatahub-io:main Sep 13, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants