Openshift-ci model-registry deployment configuration and testing #26
Conversation
…operator used in the nightly runs
…egistry-data-science-cluster-nightly.yaml
…s out the DSC_INITIALIZATION_MANAIFEST command.
…ment and the deployment tests
…lete wrongly named files
|
Output from successful local run. `Tony@WorkMac: ~/model-registry/openshift-ci/scripts (openshiftCIModelRegistryDeployNightly) $ ./oci-model-registry-deploy.sh ../resources/opendatahub-operator-deploy.yaml deploying ../resources/opendatahub-data-science-cluster.yaml deploying |
| run_deployment_tests() { | ||
| check_deployment_availability default model-registry-db | ||
| check_deployment_availability default modelregistry-sample | ||
| check_pod_status default model-registry 1 |
There was a problem hiding this comment.
isn't this pod called model-registry-db ? 🤔
There was a problem hiding this comment.
Are you referring to line 160? In line 87 the function takes the unique partial name of the pod(s) and returns a list of matching pods. I was just trying to build in a little bit of redundancy and not be too specific.
There was a problem hiding this comment.
Are you referring to line 160?
yes.
In line 87 the function takes the unique partial name of the pod(s) and returns a list of matching pods. I was just trying to build in a little bit of redundancy and not be too specific.
okay thank for clarification. I believe there are k8s functions that instead of grepping for the name prefix, you can query pod for app=modelregistry-sample or component=model-registry or the likes, I believe it would make this test logic more robust than grep-ping, but up to you.
Thanks again for the clarification
There was a problem hiding this comment.
I have changed this to use selectors instead of grep
| fi | ||
|
|
||
| # Test if the route is live | ||
| local response=$(curl -s -o /dev/null -w "%{http_code}" "$route_url/api/model_registry/v1alpha2/registered_models") |
There was a problem hiding this comment.
the v1alpha2 will likely iterate further, so eventually we might need to externalize the way the route is checked for liveliness.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tarilabs, tonyxrmdavidson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit ffa5c3f
into
opendatahub-io:main
This pull request will:
merge the script and files needed to deploy and test model-registry as part of a rhods deployment using an odh nightly image.