-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
periodic sync upstream KF to midstream ODH #27
periodic sync upstream KF to midstream ODH #27
Conversation
…ubeflow#37) Bumps google.golang.org/protobuf from 1.32.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…low#38) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.62.0 to 1.62.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.62.0...v1.62.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* OAS: fixup ID -> Id in parameter names ... to preserve camelCase. Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com> * fix REST api to use ModelVersionUpdate in PATCH method Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> * bump OAS version to v1alpha3 Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com> --------- Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com> Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> Co-authored-by: Matteo Mortari <matteo.mortari@gmail.com>
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
… /csi (kubeflow#40) Bumps google.golang.org/protobuf from 1.32.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This reverts commit aeeffc0.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…endatahub-io#27) Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.4 to 1.9.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.8.4...v1.9.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (opendatahub-io#27) Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.4 to 1.9.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.8.4...v1.9.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add first draft of model registry kserve custom storage initializer (opendatahub-io#25) * Add first draft of model registry custom storage initializer Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Add documentation and get started guide Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * fix: ensure consistency ns(omitted) for istio manifests (opendatahub-io#31) * fix: ensure consistency ns(omitted) for istio manifests Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> * add default ns to kustomization for consistency with manifests/kustomize/overlays/{db} kustomizations Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> --------- Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> * fix CVE-2024-21626 (opendatahub-io#34) see also: https://security.snyk.io/vuln/SNYK-GOLANG-GITHUBCOMCONTAINERDCONTAINERD-6219724 Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Co-authored-by: Matteo Mortari <matteo.mortari@gmail.com>
@@ -82,7 +82,7 @@ Then, in the same terminal where you exported `MR_HOSTNAME`, perform the followi | |||
|
|||
```bash | |||
curl --silent -X 'POST' \ | |||
"$MR_HOSTNAME/api/model_registry/v1alpha2/registered_models" \ | |||
"$MR_HOSTNAME/api/model_registry/v1alpha3/registered_models" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that we want to be back-compatible, but we do not have yet any stable released versions should we be changing the version numbers this aggressively? may be not right issue to ask this question either :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend that if there are any API changes we update the version number only once for the given release. I am sure you might be already doing that, just wanted to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can avoid "releasing too often", at the same time I understood we wanted to be strict on bumping the version number for every breaking change nevertheless.
Here is the short-blanket: either we minimize releases keeping the number bumps, or we release as often as needed and we relax strictness on the backward incompatibility of the REST API number. my2c.
/lgtm |
bb0a432
into
opendatahub-io:main
content:
by revert with e9167d9