Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DSCI config #35

Merged

Conversation

tonyxrmdavidson
Copy link

This commit adds a DSCI config file to create a DSCInitialization in the DSC.

Copy link

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tonyxrmdavidson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…correct default dsci needed for correct application
@tonyxrmdavidson tonyxrmdavidson requested review from tarilabs and rkubis and removed request for nehachopra27 and lampajr March 28, 2024 10:26
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have first-hand experience with DSCInitialization, but looks fine with me.

/lgtm

I would defer to @rkubis for approva

@openshift-ci openshift-ci bot added the lgtm label Mar 28, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 164d7dc into opendatahub-io:main Mar 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants