-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This commit explicitly puts model-registry resources into the opendat… #47
This commit explicitly puts model-registry resources into the opendat… #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this introduces an explicit namespace flag for all K8s api commands and the rest script.
/lgtm
I believe best if also @rkubis or @nehachopra27 can 👀 so to make sure it's consistent test-code-wise!
Thank you Tony
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rkubis, tonyxrmdavidson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest build |
@rkubis: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/test build |
@rkubis: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
34bcfbc
into
opendatahub-io:main
This commit explicitly puts model-registry resources into the opendatahub namespace.