Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This commit explicitly puts model-registry resources into the opendat… #47

Conversation

tonyxrmdavidson
Copy link

This commit explicitly puts model-registry resources into the opendatahub namespace.

@openshift-ci openshift-ci bot requested review from isinyaaa and lampajr April 17, 2024 14:01
@tonyxrmdavidson tonyxrmdavidson requested review from a team and removed request for lampajr and isinyaaa April 17, 2024 14:01
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this introduces an explicit namespace flag for all K8s api commands and the rest script.

/lgtm

I believe best if also @rkubis or @nehachopra27 can 👀 so to make sure it's consistent test-code-wise!

Thank you Tony

@openshift-ci openshift-ci bot removed the lgtm label Apr 17, 2024
Copy link

@rkubis rkubis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

Copy link

openshift-ci bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rkubis, tonyxrmdavidson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [rkubis,tonyxrmdavidson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rkubis
Copy link

rkubis commented Apr 17, 2024

/retest build

Copy link

openshift-ci bot commented Apr 17, 2024

@rkubis: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-odh-cfo
  • /test images

Use /test all to run all jobs.

In response to this:

/retest build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rkubis
Copy link

rkubis commented Apr 17, 2024

/retest

@rkubis
Copy link

rkubis commented Apr 17, 2024

/test build

Copy link

openshift-ci bot commented Apr 17, 2024

@rkubis: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-odh-cfo
  • /test images

Use /test all to run all jobs.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 34bcfbc into opendatahub-io:main Apr 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants