Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pull] main from kubeflow:main #48

Closed
wants to merge 2 commits into from
Closed

[pull] main from kubeflow:main #48

wants to merge 2 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Apr 17, 2024 •
edited
Loading

See Commits and Changes for more details.

Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

isinyaaa and others added 2 commits April 16, 2024 12:52
@isinyaaa
Py: Fix misleading errors on missing list results (#65)
65613f9 
* py: fix type annotations to return concrete types

Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>

* py: fix missing type check on empty list results

Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>

---------

Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>
@tarilabs
fix: OpenAPI ModelVersion shall contain registeredModelId property (#61)
734eb9e 
need to adapt property definition in OpenAPI
to accomodate openapi-codegen result;
according to contract (as also visible in swagger)
the ModelVersion is to contain property: registeredModelId

Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
@openshift-ci openshift-ci bot requested review from rareddy and tarilabs April 17, 2024 17:12
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pull[bot]
Once this PR has been reviewed and has the lgtm label, please assign rkubis for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 17, 2024

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pull pull bot removed the needs-ok-to-test label Apr 17, 2024
@tarilabs tarilabs mentioned this pull request Apr 18, 2024
Merged
@tarilabs
Copy link
Member

superseeded by #49

@tarilabs tarilabs closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rareddy rareddy Awaiting requested review from rareddy

@tarilabs tarilabs Awaiting requested review from tarilabs

Assignees
No one assigned
Labels
tide/merge-method-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarilabs @isinyaaa