Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from kubeflow:main #74

Merged
merged 2 commits into from
Jun 23, 2024
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Jun 22, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

isinyaaa and others added 2 commits June 21, 2024 11:41
Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
This commit will update go from go1.19 to go1.21@latest



Dependency Update: bump go from 1.19 to 1.21
This commit will change the files to specify a micro version 1.21.9 instead of a major version with @latest tag



Dependency Update: bump go from 1.19 to 1.21
This commit will revert line 113 to use the major version as a file reference.



Dependency Update: bump go from 1.19 to 1.21@latest
This commit changed the minor version from 1.21.9 to major version 1.21 on go.mod file.

Signed-off-by: tonyxrmdavidson <tonyxrmdavidson@yahoo.co.uk>
Copy link

openshift-ci bot commented Jun 22, 2024

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

openshift-ci bot commented Jun 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pull[bot], tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tarilabs
Copy link
Member

(failing on codecov report upload Details Details Details)

@tarilabs
Copy link
Member

Failing with CodeCov report upload, I retried but seems the intermittent error we get from CodeCov action every once in a while.

Details, Details, Details

Proceeding manually.

@tarilabs tarilabs merged commit 4b937e5 into opendatahub-io:main Jun 23, 2024
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants