Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update db test secrets to allow passing of prodsec scanning. #86

Merged

Conversation

tonyxrmdavidson
Copy link

This commit will allow the test credentials for the postgress and mysql databases to pass prodsec scanning.

It should stop emails being received by the team informing us we have a potential data leak because of test credentials.

Instructions on how should be done are found here.

Description

Added '# notsecret tag to database-password and database-user lines in both postgres-db.yaml and mysql-db.yaml

Added a .gitleaks.toml file to allow prodsec to scan all previous commits.

How Has This Been Tested?

It has been tested locally using gitleaks cli.

This commit will allow the test credentials for the postgress and mysql databases to pass prodsec scanning

Signed-off-by: tonyxrmdavidson <tonyxrmdavidson@yahoo.co.uk>
@openshift-ci openshift-ci bot requested review from dhirajsb and tarilabs July 1, 2024 12:09
Copy link

openshift-ci bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tonyxrmdavidson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 1, 2024
@tonyxrmdavidson tonyxrmdavidson requested review from a team and removed request for dhirajsb and tarilabs July 1, 2024 12:10
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks Tony

per my previous #76 (review)
if the samples manifests are taken from the ODH/MRO repo programmatically, one reason more to just need to maintain the .gitleaks.toml is the only source-of-truth place, my2c

@openshift-ci openshift-ci bot added the lgtm label Jul 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ef568eb into opendatahub-io:main Jul 1, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants