TLS Cluster Fix #87
Closed
TLS Cluster Fix #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the the curl commands in both scripts to use the -k flag as there were issues when working with certain openshift clusters. Signed-off-by: tonyxrmdavidson <tonyxrmdavidson@yahoo.co.uk>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tonyxrmdavidson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit will uncomment the commands in the main function. These should not be commented Signed-off-by: tonyxrmdavidson <tonyxrmdavidson@yahoo.co.uk>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
- Coverage 76.57% 68.86% -7.71%
==========================================
Files 19 19
Lines 2194 2194
Branches 101 101
==========================================
- Hits 1680 1511 -169
- Misses 319 506 +187
+ Partials 195 177 -18 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the the curl commands in both scripts to use the -k flag as there were issues when working with certain openshift clusters.
Description
A -k flag is needed to ensure the script will run against clusters that are not set up to accept self signed certs.
How Has This Been Tested?
It has been tested locally. A pdf is attached with the output of the successful run.
To verify you will need an openshift cluster deployed and be oc logged in.
Git fetch and checkout this PR
From the root of the repo run this command: ./openshift-ci/scripts/oci-model-registry-istio-tls-deploy.sh
Merge criteria: