Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py: Link to docs #88

Merged

Conversation

isinyaaa
Copy link

@isinyaaa isinyaaa commented Jul 2, 2024

Link to Model Registry readthedocs build.

Description

How Has This Been Tested?

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
@openshift-ci openshift-ci bot requested review from rkubis and tarilabs July 2, 2024 19:35
Copy link

openshift-ci bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isinyaaa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 2, 2024
@isinyaaa isinyaaa requested a review from rareddy July 2, 2024 19:36
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.57%. Comparing base (ef568eb) to head (b77c770).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   76.57%   76.57%           
=======================================
  Files          19       19           
  Lines        2194     2194           
  Branches      101      101           
=======================================
  Hits         1680     1680           
  Misses        319      319           
  Partials      195      195           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thank you @isinyaaa

@openshift-ci openshift-ci bot added the lgtm label Jul 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7956f07 into opendatahub-io:main Jul 3, 2024
14 checks passed
@isinyaaa isinyaaa deleted the push-zrnovzymnwlv branch July 3, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants