Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed DB File Needing Update To Stop Test Creds Triggering Prodsec Scan #89

Conversation

tonyxrmdavidson
Copy link

This commit will update the DB file to not trigger the prodsec security scan for test credentials. This file was missed on the initial PR to fix this issue.

Description

Added a # notsecret tag to both the DB user and DB password lines in the file. This is recommended by prodsec to highlight test credentials.

How Has This Been Tested?

Tested locally by running .gitleaks.toml file.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

This commit will update the DB file to not trigger the prodsec security scan for test credentials

Signed-off-by: tonyxrmdavidson <tonyxrmdavidson@yahoo.co.uk>
Copy link

openshift-ci bot commented Jul 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nehachopra27, tonyxrmdavidson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [nehachopra27,tonyxrmdavidson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit beb52a7 into opendatahub-io:main Jul 3, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants