Allow interactive preview of k8s resource name

opendatahub-io · Sep 25, 2024 · da72b1d · da72b1d
1 parent 7b47f42
commit da72b1d
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/frontend/src/concepts/connectionTypes/ConnectionTypeForm.tsx b/frontend/src/concepts/connectionTypes/ConnectionTypeForm.tsx
@@ -113,7 +113,7 @@ const ConnectionTypeForm: React.FC<Props> = ({
                 },
               }
             }
-            onDataChange={setConnectionNameDesc ?? (() => undefined)} // onDataChange needs to be truthy to show resource name
+            onDataChange={setConnectionNameDesc}
           />
           <ConnectionTypeFormFields
             fields={connectionType?.data?.fields}

diff --git a/frontend/src/concepts/connectionTypes/utils.ts b/frontend/src/concepts/connectionTypes/utils.ts
@@ -185,9 +185,14 @@ export const parseConnectionSecretValues = (
       matchingField.properties.variant === 'multi'
     ) {
       try {
-        response[key] = JSON.parse(decodedString);
+        const parsed = JSON.parse(decodedString);
+        if (Array.isArray(parsed)) {
+          response[key] = parsed.map((v) => String(v));
+        } else {
+          response[key] = [decodedString];
+        }
       } catch {
-        response[key] = decodedString;
+        response[key] = [decodedString];
       }
     } else {
       response[key] = decodedString;

diff --git a/frontend/src/concepts/k8s/K8sNameDescriptionField/K8sNameDescriptionField.tsx b/frontend/src/concepts/k8s/K8sNameDescriptionField/K8sNameDescriptionField.tsx
@@ -72,7 +72,7 @@ const K8sNameDescriptionField: React.FC<K8sNameDescriptionFieldProps> = ({
           value={name}
           onChange={(event, value) => onDataChange?.('name', value)}
         />
-        {!showK8sField && !!onDataChange && !k8sName.state.immutable && (
+        {!showK8sField && !k8sName.state.immutable && (
           <FormHelperText>
             {k8sName.value && (
               <HelperText>

diff --git a/frontend/src/concepts/k8s/K8sNameDescriptionField/ResourceNameField.tsx b/frontend/src/concepts/k8s/K8sNameDescriptionField/ResourceNameField.tsx
@@ -34,7 +34,7 @@ const ResourceNameField: React.FC<ResourceNameFieldProps> = ({
     return <FormGroup {...formGroupProps}>{k8sName.value}</FormGroup>;
   }
 
-  if (!allowEdit || !onDataChange) {
+  if (!allowEdit) {
     return null;
   }
 
@@ -52,7 +52,7 @@ const ResourceNameField: React.FC<ResourceNameFieldProps> = ({
         name={`${dataTestId}-resourceName`}
         isRequired
         value={k8sName.value}
-        onChange={(event, value) => onDataChange('k8sName', value)}
+        onChange={(event, value) => onDataChange?.('k8sName', value)}
         validated={validated}
       />
       <HelperText>