Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Projects view filter bar #3179

Merged

Conversation

jeff-phillips-18
Copy link
Contributor

@jeff-phillips-18 jeff-phillips-18 commented Sep 10, 2024

Closes RHOAIENG-10496

Description

Update the Project table Filter design pattern:

  • Use the attribute value filter and chip component

  • Allow filtering on both Name and User at same time, maximum of one of each

  • Allow clearing of all filters

  • Allow clearing of a single filter in the chip

  • Switching between filter type will retain the input in each field. For example, if I choose "Name" and type "admin", then switch to "User" and type "David," and then go back to "Name," I’ll still see "admin" in the search bar under the "Name" filter.

  • Adjust the old “No results” to the PatternFly updated no results.

  • How Has This Been Tested?

Tested Manually, updated e2e tests

Test Impact

Updated e2e tests

Screen shots

image

image

image

image

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

/cc @tobiastal

Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

@jeff-phillips-18: GitHub didn't allow me to request PR reviews from the following users: tobiastal.

Note that only opendatahub-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

WIP

Depends on #3173

Closes RHOAIENG-10496

Description

Update the Project table Filter design pattern:

  • Use the attribute value filter and chip component

  • Allow filtering on both Name and User at same time, maximum of one of each

  • Allow clearing of all filters

  • Allow clearing of a single filter in the chip

  • Switching between filter type will retain the input in each field. For example, if I choose "Name" and type "admin", then switch to "User" and type "David," and then go back to "Name," I’ll still see "admin" in the search bar under the "Name" filter.

  • Adjust the old “No results” to the PatternFly updated no results.

  • How Has This Been Tested?

Tested Manually, updated e2e tests

Test Impact

Updated e2e tests

Screen shots

image

image

image

image

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

/cc @tobiastal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.30%. Comparing base (2e37911) to head (f55fb3e).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
frontend/src/components/PopoverListContent.tsx 69.23% 4 Missing ⚠️
...ages/projects/screens/projects/ProjectListView.tsx 88.88% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3179      +/-   ##
==========================================
+ Coverage   85.26%   85.30%   +0.03%     
==========================================
  Files        1258     1261       +3     
  Lines       27689    27723      +34     
  Branches     7370     7375       +5     
==========================================
+ Hits        23609    23649      +40     
+ Misses       4080     4074       -6     
Files with missing lines Coverage Δ
.../pages/projects/screens/projects/EmptyProjects.tsx 100.00% <ø> (ø)
...ages/projects/screens/projects/ProjectsToolbar.tsx 100.00% <100.00%> (ø)
...ntend/src/pages/projects/screens/projects/const.ts 100.00% <100.00%> (ø)
...ages/projects/screens/projects/ProjectListView.tsx 73.80% <88.88%> (+1.08%) ⬆️
frontend/src/components/PopoverListContent.tsx 69.23% <69.23%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e37911...f55fb3e. Read the comment docs.

@jeff-phillips-18 jeff-phillips-18 changed the title [WIP] Update Projects view filter bar Update Projects view filter bar Sep 12, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Sep 12, 2024
@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4ca067b into opendatahub-io:main Sep 12, 2024
8 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the project-filter-bar branch September 12, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants