-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Projects view filter bar #3179
Update Projects view filter bar #3179
Conversation
@jeff-phillips-18: GitHub didn't allow me to request PR reviews from the following users: tobiastal. Note that only opendatahub-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
d934057
to
9d117fb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3179 +/- ##
==========================================
+ Coverage 85.26% 85.30% +0.03%
==========================================
Files 1258 1261 +3
Lines 27689 27723 +34
Branches 7370 7375 +5
==========================================
+ Hits 23609 23649 +40
+ Misses 4080 4074 -6
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
9d117fb
to
f55fb3e
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes RHOAIENG-10496
Description
Update the Project table Filter design pattern:
Use the attribute value filter and chip component
Allow filtering on both Name and User at same time, maximum of one of each
Allow clearing of all filters
Allow clearing of a single filter in the chip
Switching between filter type will retain the input in each field. For example, if I choose "Name" and type "admin", then switch to "User" and type "David," and then go back to "Name," I’ll still see "admin" in the search bar under the "Name" filter.
Adjust the old “No results” to the PatternFly updated no results.
How Has This Been Tested?
Tested Manually, updated e2e tests
Test Impact
Updated e2e tests
Screen shots
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
/cc @tobiastal