Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-11010] Use a more secure role for KServe InferenceService access #3198

Merged
merged 5 commits into from
Sep 26, 2024

Add missing rules to service account role

a122ad0
Select commit
Loading
Failed to load commit list.
Merged

[RHOAIENG-11010] Use a more secure role for KServe InferenceService access #3198

Add missing rules to service account role
a122ad0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 26, 2024 in 0s

84.87% (+0.02%) compared to 47aabd3

View this Pull Request on Codecov

84.87% (+0.02%) compared to 47aabd3

Details

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.87%. Comparing base (47aabd3) to head (a122ad0).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
frontend/src/pages/modelServing/utils.ts 94.11% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3198      +/-   ##
==========================================
+ Coverage   84.84%   84.87%   +0.02%     
==========================================
  Files        1299     1300       +1     
  Lines       28920    28945      +25     
  Branches     7771     7777       +6     
==========================================
+ Hits        24538    24567      +29     
+ Misses       4382     4378       -4     
Files with missing lines Coverage Δ
frontend/src/api/k8s/roleBindings.ts 96.66% <100.00%> (ø)
frontend/src/api/k8s/roles.ts 100.00% <100.00%> (ø)
frontend/src/api/models/k8s.ts 100.00% <100.00%> (ø)
frontend/src/k8sTypes.ts 100.00% <ø> (ø)
...d/src/pages/modelServing/screens/projects/utils.ts 96.84% <ø> (ø)
frontend/src/pages/modelServing/utils.ts 93.37% <94.11%> (-0.01%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47aabd3...a122ad0. Read the comment docs.