Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address UX items with connection types #3201

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

christianvogt
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-12827

Description

Addresses the following UX items for connection types:

Connection type filter changed from Created By to Creator:
image

Microcopy of fields name header updated with spacing around the /:
image

Long env var names get truncated in table. Include screenshots for when env var names are in conflict.
image
image
image

When duplicating a section or data field, the name starts with Copy of:
image
image

Dropdown field updates.
When no items are defined:
image

When items are defined but no field name:
image
image

When field name is defined (eg. testing):
image
image

Added spacing between modal description and form by moving the text inside the form which applies the default spacing between form elements:
image

How Has This Been Tested?

Manual verification

  • Enable the connection types feature flag and navigate to Settings => Connection types

Test Impact

N/A visual impacts only

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

cc @simrandhaliw

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.28%. Comparing base (2e37911) to head (51b0549).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...cepts/connectionTypes/fields/DropdownFormField.tsx 93.75% 1 Missing ⚠️
...es/connectionTypes/ConnectionTypesTableToolbar.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3201      +/-   ##
==========================================
+ Coverage   85.26%   85.28%   +0.01%     
==========================================
  Files        1258     1258              
  Lines       27689    27692       +3     
  Branches     7370     7375       +5     
==========================================
+ Hits        23609    23617       +8     
+ Misses       4080     4075       -5     
Files with missing lines Coverage Δ
...src/pages/connectionTypes/ConnectionTypesTable.tsx 81.81% <100.00%> (+1.81%) ⬆️
frontend/src/pages/connectionTypes/const.ts 100.00% <100.00%> (ø)
...ctionTypes/manage/ConnectionTypeFieldMoveModal.tsx 100.00% <ø> (ø)
...ypes/manage/ManageConnectionTypeFieldsTableRow.tsx 86.20% <100.00%> (ø)
.../pages/connectionTypes/manage/fieldTableColumns.ts 100.00% <ø> (ø)
...cepts/connectionTypes/fields/DropdownFormField.tsx 83.92% <93.75%> (-0.39%) ⬇️
...es/connectionTypes/ConnectionTypesTableToolbar.tsx 84.21% <0.00%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e37911...51b0549. Read the comment docs.

Copy link
Contributor

openshift-ci bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3a76f55 into opendatahub-io:main Sep 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants