Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update table filters into separate chip groups #3202

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

christianvogt
Copy link
Contributor

@christianvogt christianvogt commented Sep 12, 2024

https://issues.redhat.com/browse/RHOAIENG-12827

Description

How Has This Been Tested?

Manually hitting the different areas of the UI.

Connection type before and after:
image
image

Pipelines before and after:
image
image

All affected areas:

  • /connectionTypes
  • /pipelines/<namespace>
  • /experiments/<namespace>
  • /experiments/<namespace>/archived
  • /executions/<namespace>
  • /artifacts/<namespace>
  • /projects

Test Impact

Existing cypress tests.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

cc @simrandhaliw

@christianvogt christianvogt added the do-not-merge/hold This PR is hold for some reason label Sep 12, 2024
@christianvogt christianvogt removed the do-not-merge/hold This PR is hold for some reason label Sep 13, 2024
@christianvogt christianvogt changed the title separate table filters into separate chip groups update table filters into separate chip groups Sep 13, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.33%. Comparing base (06e065b) to head (3ba2a8c).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
frontend/src/components/FilterToolbar.tsx 86.66% 2 Missing ⚠️
...cepts/connectionTypes/fields/DropdownFormField.tsx 93.75% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3202      +/-   ##
==========================================
+ Coverage   85.29%   85.33%   +0.03%     
==========================================
  Files        1266     1267       +1     
  Lines       27800    27827      +27     
  Branches     7400     7413      +13     
==========================================
+ Hits        23712    23745      +33     
+ Misses       4088     4082       -6     
Files with missing lines Coverage Δ
frontend/src/components/table/TableBase.tsx 100.00% <100.00%> (ø)
...nes/content/compareRuns/CompareRunTableToolbar.tsx 84.61% <ø> (+12.82%) ⬆️
.../content/tables/experiment/ExperimentTableBase.tsx 88.88% <100.00%> (ø)
...ntent/tables/experiment/ExperimentTableToolbar.tsx 87.50% <ø> (+4.16%) ⬆️
...pelines/content/tables/pipeline/PipelinesTable.tsx 97.36% <100.00%> (+0.07%) ⬆️
...pipelineRecurringRun/PipelineRecurringRunTable.tsx 100.00% <100.00%> (ø)
...eRecurringRun/PipelineRecurringRunTableToolbar.tsx 100.00% <ø> (+5.55%) ⬆️
...es/content/tables/pipelineRun/PipelineRunTable.tsx 83.72% <100.00%> (ø)
...ent/tables/pipelineRun/PipelineRunTableToolbar.tsx 100.00% <ø> (+2.38%) ⬆️
...epts/pipelines/content/tables/usePipelineFilter.ts 98.07% <ø> (ø)
... and 17 more

... and 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06e065b...3ba2a8c. Read the comment docs.

@jeff-phillips-18
Copy link
Contributor

Ran thru the filters, works well.
/lgtm

Copy link
Contributor

openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@christianvogt
Copy link
Contributor Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit ec193eb into opendatahub-io:main Sep 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants