Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events are in correct order in workbench status progress #3253

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Sep 25, 2024

https://issues.redhat.com/browse/RHOAIENG-11107

Description

sort the events by their timestamp in the StartServerModal and startNotebookModal

How Has This Been Tested?

  1. Create a workbench
  2. and check for the event log whether its sorted, compare the event to workbench pod events in openshift console
  3. also Verify the event logs for notebook server
    Workench:
Screenshot 2024-09-25 at 7 26 21 PM

Notebook server

Screenshot 2024-09-25 at 7 29 39 PM

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.84%. Comparing base (d5938bf) to head (65d13c8).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...src/pages/projects/notebook/StartNotebookModal.tsx 0.00% 2 Missing ⚠️
...bookController/screens/server/StartServerModal.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3253      +/-   ##
==========================================
- Coverage   85.06%   84.84%   -0.22%     
==========================================
  Files        1293     1299       +6     
  Lines       28846    28924      +78     
  Branches     7759     7771      +12     
==========================================
+ Hits        24538    24541       +3     
- Misses       4308     4383      +75     
Files with missing lines Coverage Δ
...bookController/screens/server/StartServerModal.tsx 54.94% <50.00%> (-0.12%) ⬇️
...src/pages/projects/notebook/StartNotebookModal.tsx 4.28% <0.00%> (-54.54%) ⬇️

... and 42 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5938bf...65d13c8. Read the comment docs.

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks for the change

Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3ec224f into opendatahub-io:main Sep 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants