Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout issues on notebook controller #3258

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Sep 25, 2024

JIRA: RHOAIENG-1202

Description

Remove the div on the administration page to make it use the full width:

Screenshot 2024-09-25 at 5 19 04 PM

Fix the loading state by adding the loadingContent to the applications page to remove the background.

Screenshot 2024-09-25 at 5 20 52 PM

How Has This Been Tested?

Go to the notebook controller page and switch between the Notebook Server and Administration tab. See how the loading state renders, Make sure there is no layout issue.

Test Impact

N/A, layout fix.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@pnaik1
Copy link
Contributor

pnaik1 commented Sep 26, 2024

/retest

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.85%. Comparing base (47aabd3) to head (d347f01).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3258   +/-   ##
=======================================
  Coverage   84.84%   84.85%           
=======================================
  Files        1299     1299           
  Lines       28920    28920           
  Branches     7771     7771           
=======================================
+ Hits        24538    24540    +2     
+ Misses       4382     4380    -2     
Files with missing lines Coverage Δ
...kController/screens/admin/NotebookAdminControl.tsx 100.00% <100.00%> (ø)
.../notebookController/screens/server/SpawnerPage.tsx 64.55% <ø> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47aabd3...d347f01. Read the comment docs.

@pnaik1
Copy link
Contributor

pnaik1 commented Sep 26, 2024

Verified on a cluster
there is no layout issue.
/lgtm

Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 42c4f3d into opendatahub-io:main Sep 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants