Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MR fixes identified during architecture review #3263

Merged
merged 4 commits into from
Sep 27, 2024
Merged

MR fixes identified during architecture review #3263

merged 4 commits into from
Sep 27, 2024

Commits on Sep 27, 2024

  1. Remove stale TODO - we do need the code in question 

    Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
    @mturley
    mturley committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    84e7950 View commit details
    Browse the repository at this point in the history

  2. Properly return promise when deleting a registry 

    Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
    @mturley
    mturley committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f6b8fd7 View commit details
    Browse the repository at this point in the history

  3. Exclude namespace when sending MR rolebindings to the backend service… 

    … due to requestSecurityGuard

Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
    @mturley
    mturley committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    84eb438 View commit details
    Browse the repository at this point in the history

  4. Fix tests 

    Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
    @mturley
    mturley committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    3b6b067 View commit details
    Browse the repository at this point in the history