Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update useGenericObjectState types #3274

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

christianvogt
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-9748

Description

Improves the typing of useGenericObjectState such that the value is properly typed depending on the supplied property key. As a result, any unmatched value will result in a typescript error.

Extracted common types for model serving into a separate type definition to be used by common form components.

Additionally, updated useGenericObjectState to accept a function to coincide with the API of useState. This function argument can be used when the computation of default data is expensive.

How Has This Been Tested?

npm run test:type-check
Ran existing tests.

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

openshift-ci bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from christianvogt. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.83%. Comparing base (228e221) to head (6799579).

Files with missing lines Patch % Lines
...projects/NIMServiceModal/DeployNIMServiceModal.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3274      +/-   ##
==========================================
- Coverage   84.87%   84.83%   -0.04%     
==========================================
  Files        1306     1306              
  Lines       29196    29199       +3     
  Branches     7885     7885              
==========================================
- Hits        24780    24771       -9     
- Misses       4416     4428      +12     
Files with missing lines Coverage Δ
...epts/pipelines/content/createRun/useRunFormData.ts 88.75% <100.00%> (ø)
...elRegistry/screens/RegisterModel/RegisterModel.tsx 100.00% <100.00%> (ø)
...Registry/screens/RegisterModel/RegisterVersion.tsx 88.57% <100.00%> (-0.32%) ⬇️
...iceModal/InferenceServiceServingRuntimeSection.tsx 94.73% <100.00%> (ø)
.../ServingRuntimeModal/AuthServingRuntimeSection.tsx 93.10% <ø> (ø)
.../ServingRuntimeModal/ManageServingRuntimeModal.tsx 93.33% <100.00%> (+0.18%) ⬆️
...ngRuntimeModal/ServingRuntimeSizeExpandedField.tsx 77.77% <ø> (ø)
.../ServingRuntimeModal/ServingRuntimeSizeSection.tsx 97.50% <ø> (ø)
...s/ServingRuntimeModal/ServingRuntimeTokenInput.tsx 48.48% <ø> (ø)
...ServingRuntimeModal/ServingRuntimeTokenSection.tsx 89.47% <ø> (ø)
... and 5 more

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 228e221...6799579. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant