update useGenericObjectState types #3274
Open
+43
−70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHOAIENG-9748
Description
Improves the typing of
useGenericObjectState
such that the value is properly typed depending on the supplied property key. As a result, any unmatched value will result in a typescript error.Extracted common types for model serving into a separate type definition to be used by common form components.
Additionally, updated
useGenericObjectState
to accept a function to coincide with the API ofuseState
. This function argument can be used when the computation of default data is expensive.How Has This Been Tested?
npm run test:type-check
Ran existing tests.
Test Impact
N/A
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main