Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List connected deployed models for each connection table row #3275

Merged

Conversation

jeff-phillips-18
Copy link
Contributor

Closes RHOAIENG-11558

Description

Adds connected deployed models to the connection table rows.
Lists connected deployed models when deleting a connection.

How Has This Been Tested?

Tested manually.
Added test scenarios

Test Impact

Test the connection table to verify the related models show up in each row
Test the delete connection modal to verify the related models are listed.

Screen shots

image

image

image

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

/cc @simrandhaliw

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.88%. Comparing base (228e221) to head (9a3179f).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...eens/detail/connections/ConnectionsDeleteModal.tsx 92.85% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3275      +/-   ##
==========================================
+ Coverage   84.87%   84.88%   +0.01%     
==========================================
  Files        1306     1307       +1     
  Lines       29196    29216      +20     
  Branches     7885     7892       +7     
==========================================
+ Hits        24780    24801      +21     
+ Misses       4416     4415       -1     
Files with missing lines Coverage Δ
.../screens/detail/connections/ConnectedResources.tsx 91.66% <100.00%> (+2.77%) ⬆️
...ages/projects/useInferenceServicesForConnection.ts 100.00% <100.00%> (ø)
...eens/detail/connections/ConnectionsDeleteModal.tsx 85.71% <92.85%> (+1.33%) ⬆️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 228e221...9a3179f. Read the comment docs.

@emilys314
Copy link
Contributor

the functionality checks out
image
image

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9ab1076 into opendatahub-io:main Oct 2, 2024
8 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the connected-models branch October 4, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants